Skip to content

Resolve issue with Issue with calling persistence.migrate with no par…#175

Open
jaylagare wants to merge 1 commit intocoresmart:masterfrom
jaylagare:master
Open

Resolve issue with Issue with calling persistence.migrate with no par…#175
jaylagare wants to merge 1 commit intocoresmart:masterfrom
jaylagare:master

Conversation

@jaylagare
Copy link

Per documentation: persistence.migrate() to run migrations up to the most recent

I encountered an issue where calling persistence.migrate with no parameters didn't do anything. Checking the code of persistence.migrations.js, I found the problem where version is undefined and thus no migration is done and only the callback is called:
if (curVersion < version)
Migrator.migrateUpTo(version, callback);
else if (curVersion > version)
Migrator.migrateDownTo(version, callback);
else
callback();

Solution is to update code from:
migrate: function(version, callback) {
if ( arguments.length === 1) {
callback = version;
version = this.migrations.length-1;
}

to:
migrate: function(version, callback) {
if ( arguments.length === 1) {
callback = version;
}
if (arguments.lemgth <= 1) {
version = this.migrations.length-1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant