Added 5 try-catch blocks around tx.executeSql calls.#85
Open
MarkMYoung wants to merge 2 commits intocoresmart:masterfrom
MarkMYoung:patch-2
Open
Added 5 try-catch blocks around tx.executeSql calls.#85MarkMYoung wants to merge 2 commits intocoresmart:masterfrom MarkMYoung:patch-2
MarkMYoung wants to merge 2 commits intocoresmart:masterfrom
MarkMYoung:patch-2
Conversation
Collaborator
|
Thanks! But can you perhaps fix your code indentation and coding style slightly to fit the rest of persistence.js? i.e. move curly braces to the end of the line, and indent code properly? |
…es, I just copied-and-pasted from my code and assumed github had a code (re-)formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was hoping to roll up my 4 modified files into one pull request, but I don't know how to do that. My changes add better error handling and some more verbose logging when in debug mode.