Speed up MatmulLinearOperator.to_dense() for DiagLazyTensors #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can help substantially if some of the operators involved are `DiagLinearOperator`s. This fixes the issue reported in meta-pytorch/botorch#3159
Collaborator
Author
|
Only the last commit is relevant here; the rest comes from #121 |
Closed
1 task
Member
|
Can we rebase this once the jaxtyping removal goes in? This is a little crazystyle to review at the moment since it touches basically every file in the repo. Edit: Oh I see the point of your comment now, we can just review the diff from the last commit. |
jacobrgardner
approved these changes
Feb 3, 2026
Member
jacobrgardner
left a comment
jacobrgardner
left a comment
There was a problem hiding this comment.
Yeah approved assuming the last commit is the only real diff here, that's an obvious speed win.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can help substantially if some of the operators involved are
DiagLinearOperators.This fixes the issue reported in meta-pytorch/botorch#3159