fix: hide CMD window on Windows when spawning shell commands#44
Open
cl1107 wants to merge 1 commit into
Open
Conversation
… Windows Both run_command and background-tasks open a visible cmd.exe window when spawning shell commands on Windows. Adding windowsHide: true suppresses this behavior. The daemon.ts already uses this option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, shell commands spawn a visible cmd.exe window that flashes on screen, degrading user experience.
Fix
Add to options in two files:
This is a Node.js built-in option (v13.3+) that suppresses the console window on Windows. The daemon launcher () already uses this pattern.
Test Plan