Skip to content

feat: add FileStore implementation for cache (#427) #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
achsanalfitra wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat: add FileStore implementation for cache (#427) #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f571f6c
wip: reset branch to match master
achsanalfitra Jan 21, 2026
3b05a5f
fix: dependency
achsanalfitra Jan 21, 2026
da541c8
fix: add branch for windows error code
achsanalfitra Jan 22, 2026
98c4bf6
fix: unpack inner boolean properly on try_lock_exclusive to use the n…
achsanalfitra Jan 22, 2026
0adfa9e
fix: access denied on rename on Windows
achsanalfitra Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ async-stream = "0.3"
async-trait = "0.1"
axum = { version = "0.8", default-features = false }
backtrace = "0.3.76"
blake3 = "1.8.3"
bytes = "1.11"
cargo_toml = "0.22"
chrono = { version = "0.4.42", default-features = false }
Expand All @@ -88,6 +89,7 @@ email_address = "0.2.9"
fake = "4"
fantoccini = "0.22"
form_urlencoded = "1"
fs4 = { version = "0.13.1", features = ["tokio", "sync"] }
futures = { version = "0.3", default-features = false }
futures-core = { version = "0.3", default-features = false }
futures-util = { version = "0.3", default-features = false }
Expand Down
2 changes: 2 additions & 0 deletions cot/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ askama = { workspace = true, features = ["std"] }
async-trait.workspace = true
axum = { workspace = true, features = ["http1", "tokio"] }
backtrace.workspace = true
blake3.workspace = true
Copy link
Member

@m4tx m4tx Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically this should also be an optional dependency, but since we plan to switch static files to use blake3 instead of sha2, it's fine to leave this as-is.

bytes.workspace = true
chrono = { workspace = true, features = ["alloc", "serde", "clock"] }
chrono-tz.workspace = true
Expand All @@ -34,6 +35,7 @@ digest.workspace = true
email_address.workspace = true
fake = { workspace = true, optional = true, features = ["derive", "chrono"] }
form_urlencoded.workspace = true
fs4.workspace = true
Copy link
Member

@m4tx m4tx Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since cache is an optional feature, this could be an optional dependency, too.

futures-core.workspace = true
futures-util.workspace = true
hex.workspace = true
Expand Down
1 change: 1 addition & 0 deletions cot/src/cache/store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
//! provide a simple asynchronous interface for putting, getting, and managing
//! cached values, optionally with expiration policies.

pub mod file;
Copy link
Member

@m4tx m4tx Jan 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a full implementation, please take a look at config.rs whether it also needs to be modified, so that the users can easily switch between cache implementations in the config TOML file. This will also require a change here:

cot/cot/src/cache.rs

Line 791 in 01aeef5

_ => {

pub mod memory;
#[cfg(feature = "redis")]
pub mod redis;
Expand Down
Loading
Loading