Fix 'passphase' typo — should be 'passphrase'#172
Merged
toddr merged 1 commit intocpan-authors:mainfrom Apr 23, 2026
Merged
Conversation
The original passphrase support (added in 0.33) introduced the typo 'passphase' in variable names, XS parameter names, and POD documentation. This corrects it everywhere: RSA.xs internal names, RSA.pm POD for get_private_key_string, and the $passphase test variable in t/format.t. No functional change — all names are internal (positional parameters). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
Rebase with conflict resolutionBranch StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
toddr-bot
force-pushed
the
koan.toddr.bot/fix-passphrase-typo
branch
from
d217745 to
c90b672
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the persistent
passphasetypo (missing 'r') topassphraseacross RSA.xs, RSA.pm POD, README.md, and t/format.t.Why
The original passphrase support (0.33) introduced the misspelling
passphasein variable names and documentation. The POD was inconsistent:new_private_keycorrectly used "passphrase" whileget_private_key_stringused "passphase". Users reading the docs see the wrong parameter name.How
Pure rename — all affected names are internal C variables and XS positional parameters (no API change). The POD and README are corrected so users see "passphrase" consistently.
Changesleft untouched (historical record).Testing
Full test suite passes (
make test). No functional change — only identifier and documentation spelling.🤖 Generated with Claude Code
Quality Report
Changes: 4 files changed, 40 insertions(+), 40 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline