fix: improve POD accuracy and add explicit -s guard#101
Draft
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: improve POD accuracy and add explicit -s guard#101Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
- Document CHECK_IS_NULL in the "Check helpers" section (was exported but undocumented, leaving users unaware of how to signal "file not found") - Fix NV op description: -M/-C/-A return fractional days, not integers - Document that stat hash keys accept bare forms (uid, size) in addition to st_* prefixed forms, and that unknown keys are rejected - Update outdated "very early development stage" notice - Fix two broken internal POD links (/"Mocking stat", /" Mocking all...") - Add explicit CHECK_IS_NULL guard to -s handler in _check_from_stat for consistency with -e, -M, -C, -A, -T, -B handlers (behavior was already correct via accidental undef propagation through _check) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes several documentation inaccuracies in the POD and adds an explicit
guard to the
-shandler for consistency with sibling handlers.Why
CHECK_IS_NULLis exported and essential for signaling "file not found"from mock callbacks, but was missing from the documented helper list —
users had to discover it from source or tests.
-s/-M/-C/-Adescription said "integers" but-M/-C/-Areturn fractional days (NV), not integers.
stat_as_*accept bare keys (uid,size) via normalization, but thedocs only listed
st_*forms — users writing{ size => 42 }had noconfirmation it was supported.
-shandler in_check_from_statwas the only handler without anexplicit
@statguard, relying on accidental undef propagation.How
Single-file change in
lib/Overload/FileCheck.pm— POD sections updated,one line added to the
-sdispatch handler.Testing
make test— all tests pass.podcheckerclean (was showing 2 errors before fix).🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 14 insertions(+), 8 deletions(-)
Code scan: clean
Tests: passed (0 Tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline