feat: add (?(R)...) recursion conditional support#34
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
feat: add (?(R)...) recursion conditional support#34toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
Add three new node types for recursion conditions in (?(...)...) syntax: - groupr: bare (?(R)...) — tests if inside any recursion - grouprn: (?(R1)...) — tests if recursing into group N - grouprname: (?(R&name)...) — tests if recursing into named group These are valid Perl 5.10+ constructs that were previously rejected with "Unknown switch condition" errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for
(?(R)...),(?(R1)...), and(?(R&name)...)recursion conditionals.Why
These are valid Perl 5.10+ constructs that were previously rejected with "Unknown switch condition" errors. They test whether the current position is inside a recursive call — essential for writing recursive patterns like balanced parentheses or nested structures.
How
Three new node types in Objects.pm, all with
family => 'groupp'(consistent with existing condition nodes):groupr— bare recursion checkgrouprn— numbered group recursion check (withnparen()accessor)grouprname— named group recursion check (withname()accessor)Handler detection added in
ifthen(before the single-char dispatch, matchingR),R\d+), andR&name)patterns.Testing
All 1264 tests pass (109 new). New
t/19recurse_cond.tcovers walker tree structure, round-trips, and node accessors. Existing round-trip test updated with recursion conditional patterns.🤖 Generated with Claude Code
Quality Report
Changes: 5 files changed, 328 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline