fix: validate charset flag conflicts in (?...) groups#45
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: validate charset flag conflicts in (?...) groups#45toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
Perl 5.14+ treats charset flags (a/d/l/u) as mutually exclusive: only one may be active, with 'aa' as the sole valid doubling. The parser accepted all combinations silently, producing nodes with conflicting charset semantics. Three new error codes matching Perl's native errors: - RPe_DUPLCH: doubled d/l/u (e.g. (?dd:...)) - RPe_EXCLCH: conflicting charset flags (e.g. (?al:...), (?du:...)) - RPe_NEGCHR: charset flags after - (e.g. (?-a:...)) Validated in both grouped (?xx:...) and toggle (?xx) forms, with and without caret reset syntax. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject mutually exclusive charset flags (a/d/l/u) in
(?...)flag groups, matching Perl's behavior since 5.14.Why
Perl treats
(?al:...),(?du:...),(?dd:...), and(?-a:...)as errors. The parser silently accepted all of these, producing nodes with contradictory charset semantics. Any tool using the parser to validate regexes would miss these errors.How
Three new error codes in Diagnostics.pm, validation in the
(?handler's flag-parsing loops:RPe_DUPLCH) and any cross-charset combination (RPe_EXCLCH).aa(strict ASCII) is the sole valid doubling.-(RPe_NEGCHR), matching Perl's "may not appear after the '-'" error.Testing
🤖 Generated with Claude Code
Quality Report
Changes: 5 files changed, 86 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline