fix: qr() emits hex escapes for \N{NAME} portability#46
Draft
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: qr() emits hex escapes for \N{NAME} portability#46toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
toddr-bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
\N{NAME} must be resolved by Perl's lexer at compile time. When the
parser emitted \N{NAME} literally in qr() output, the resulting pattern
could not be compiled as a runtime regex on any Perl version. Since the
parser already resolves named characters at parse time via nchar(), the
fix is to emit \x{HH} hex escapes in qr() while preserving \N{NAME}
in visual() for human-readable display.
Fixes both exact nodes and anyof_char (character class) nodes.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
qr()now emits\x{HH}hex escapes for\N{NAME}nodes instead of the literal\N{NAME}form.Why
\N{NAME}must be resolved by Perl's lexer at compile time — it cannot appear in a runtime-compiled regex pattern. The parser already resolves named characters to their code points at parse time vianchar(), but theqr()method was re-emitting the\N{NAME}source form, making the compiled pattern unusable on all Perl versions.How
Added
qr()overrides toexactandanyof_charobjects that detect\N{...}in the visual form and emit\x{HH}hex escapes using the already-resolved character data.visual()is unchanged — it still shows\N{NAME}for human readability.Testing
t/99misc.tcovering exact nodes, character classes, compilation, and matching\N{LATIN SMALL LETTER A}→qr: (?^:\x{61})✓[\N{LATIN SMALL LETTER A}-\N{LATIN SMALL LETTER Z}]→qr: (?^:[\x{61}-\x{7A}])✓🤖 Generated with Claude Code