fix: harden t/gh10.t skip logic and update stale docs#135
Draft
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Draft
fix: harden t/gh10.t skip logic and update stale docs#135Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Koan-Bot wants to merge 1 commit intocpan-authors:mainfrom
Conversation
- t/gh10.t: Also verify UTC offset (-7h for PDT) in skip check, not just DST flag. Prevents false-positive test execution on systems where TZ assignment fails but the host timezone has DST for the test epoch (GH#99). - Date::Format POD: Update LIMITATION section to note that 64-bit Perl (5.12+) supports dates beyond 2038 (GH#43). - Date::Parse POD: Add MISSING YEAR INFERENCE section documenting the "most recent past" heuristic when year is omitted (GH#46). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a flapping test and updates outdated documentation.
Why
t/gh10.tcan fail on systems whereTZ='America/Los_Angeles'doesn't take effect but the host's native timezone has DST active for the test epoch. The skip check only verified the DST flag, not the actual UTC offset.How
Time::Zone::calc_off()verification to the skip condition — ensures the offset is actually -7h (PDT) before proceeding.MISSING YEAR INFERENCEPOD section to Parse.pm documenting the "most recent past" heuristic.Testing
Full test suite passes. Verified the skip logic correctly skips on a UTC system and proceeds on a system with America/Los_Angeles support.