Skip to content

Add constexpr and noexcept to Size and PrivateSize #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twilight-debugger wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add constexpr and noexcept to Size and PrivateSize #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions 03-Style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,21 +56,23 @@ struct Size
int width;
int height;

Size(int t_width, int t_height) : width(t_width), height(t_height) {}
constexpr explicit Size(int t_width, int t_height) : width(t_width), height(t_height) {}
};

// This version might make sense for thread safety or something,
// but more to the point, sometimes we need to hide data, sometimes we don't.
class PrivateSize
{
public:
int width() const { return m_width; }
int height() const { return m_height; }
PrivateSize(int t_width, int t_height) : m_width(t_width), m_height(t_height) {}

private:
int m_width;
int m_height;
public:
constexpr int width() const noexcept { return m_width; }
constexpr int height() const noexcept { return m_height; }

constexpr explicit PrivateSize(int t_width, int t_height)
: m_width(t_width), m_height(t_height) {}

private:
int m_width;
int m_height;
};
```

Expand Down