use system libs by default #1077
Open
+178
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizvekov
force-pushed
the
default_use_system_libs
branch
from
45090b7 to
0bd333b
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1077 +/- ##
===========================================
+ Coverage 86.19% 86.41% +0.22%
===========================================
Files 323 323
Lines 23954 23955 +1
===========================================
+ Hits 20646 20700 +54
+ Misses 3308 3255 -53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mizvekov
force-pushed
the
default_use_system_libs
branch
from
0bd333b to
53cefa2
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
3 times, most recently
from
8e86b01 to
e7ae03a
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
4 times, most recently
from
f739971 to
244d6ce
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
5 times, most recently
from
44a71c2 to
350cc17
Compare
|
| Scope | Lines Δ | Lines + | Lines - | Files Δ | Files + | Files ~ | Files ↔ | Files - |
|---|---|---|---|---|---|---|---|---|
| ⚙️ CI | 61 | 45 | 16 | 1 | - | 1 | - | - |
| 🥇 Golden Tests | 49 | 27 | 22 | 9 | 4 | 5 | - | - |
| 🧪 Unit Tests | 46 | 41 | 5 | 4 | 1 | 3 | - | - |
| 🛠️ Source | 37 | 23 | 14 | 6 | - | 6 | - | - |
| 📄 Docs | 31 | 25 | 6 | 3 | - | 3 | - | - |
| 🏗️ Build / Toolchain | 28 | 12 | 16 | 2 | - | 2 | - | - |
| 🧰 Tooling | 6 | 5 | 1 | 2 | - | 2 | - | - |
| Total | 258 | 178 | 80 | 27 | 5 | 22 | - | - |
Legend: Files + (added), Files ~ (modified), Files ↔ (renamed), Files - (removed)
🔝 Top Files
- .github/workflows/ci.yml (CI): 61 lines Δ (+45 / -16)
- test-files/golden-tests/symbols/function/sfinae.xml (Golden Tests): 34 lines Δ (+17 / -17)
- test-files/include/type_traits (Unit Tests): 32 lines Δ (+32 / -0)
mizvekov
force-pushed
the
default_use_system_libs
branch
12 times, most recently
from
bb8d10e to
be98305
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
8 times, most recently
from
e86cab5 to
32ca7a3
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
7 times, most recently
from
5023cfd to
565c485
Compare
mizvekov
force-pushed
the
default_use_system_libs
branch
6 times, most recently
from
e1ead36 to
3bf984d
Compare
This change makes mrdocs use the system includes by default instead of the bundled ones. This helps mrdocs build projects which rely on differences between standard library implementations, since now mrdocs sees the source code closer to what the original compiler did, with only potential differences in the compilers themselves and some minor command line manipulations remaining. It also stops bundling the clang resource directory, relying on the one installed with libclang. This makes it so installing both to the same prefix be necessary, which is the same as all the other libclang based tools.
mizvekov
force-pushed
the
default_use_system_libs
branch
from
3bf984d to
11a7b1e
Compare
|
An automated preview of the documentation is available at https://1077.mrdocs.prtest2.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2025-12-29 15:12:36 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes mrdocs use the system includes by default instead of the bundled ones.
This helps mrdocs build projects which rely on differences between standard library implementations, since now mrdocs sees the source code closer to what the original compiler did, with only potential differences in the compilers themselves and some minor command line manipulations remaining.
It also stops bundling the clang resource directory, relying on the one installed with libclang.
This makes it so installing both to the same prefix be necessary, which is the same as all the other libclang based tools.