Fix tests

[jmendeza]

Fix tests

Summary by CodeRabbit

• Tests
  • Updated test assertions for page dependency path resolution to verify correct /index.xml suffix handling for non-index page links.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f8bcfe0b-4efb-49f5-9685-cde797e68d94

📥 Commits

Reviewing files that changed from the base of the PR and between 4adf04e and 83c6deb.

📒 Files selected for processing (2)

• src/test/java/org/craftercms/studio/impl/v1/service/dependency/RelativePageDependencyResolverTest.java
• src/test/resources/crafter/studio/upgrade/xslt/resolver-config/5.0/5.0.0.1/expected.xml

---

Walkthrough

Updated test expectations and XSLT transform configurations to append /index.xml suffix to resolved dependency paths for non-index page links in the dependency resolver. Changes span test assertions and expected XML transform definitions while maintaining existing match patterns and test input structure.

Changes

Cohort / File(s)	Summary
Test Assertions src/test/java/org/craftercms/studio/impl/v1/service/dependency/RelativePageDependencyResolverTest.java	Updated four test assertion expectations to include /index.xml suffix in resolved dependency paths for non-index page link references.
XSLT Transform Configuration src/test/resources/crafter/studio/upgrade/xslt/resolver-config/5.0/5.0.0.1/expected.xml	Modified three transform replace directives to append /index.xml to the computed page path in dependency href resolution patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add index.xml to page dependencies if missing #3844: Modifies dependency resolver XSLT and expected transforms for href handling to change index.xml treatment in similar resolver patterns.
• Fix resolver config for relative urls #3901: Makes identical code-level changes to append /index.xml to dependency resolver paths and updates corresponding test expectations.
• Dependency resolver to support relative page paths #3820: Updates dependency-resolver configuration and tests for relative page href handling, touching the same resolver functionality.

Suggested reviewers

• sumerjabri

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Fix tests' is vague and generic, providing no meaningful information about what tests are being fixed or why.	Provide a more descriptive title that specifies which tests are being fixed and the nature of the fix (e.g., 'Update test assertions for dependency resolver index.xml suffix').

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}