css refactor: Convert color scss variables to css variables#5223
Merged
veganstraightedge merged 1 commit intocrimethinc:mainfrom Apr 2, 2026
Merged
Conversation
Bargraph6
force-pushed
the
css-refactor-color-variables
branch
from
1b2cb80 to
ced5813
Compare
Bargraph6
requested review from
astronaut-wannabe,
bookis,
eliduke,
evanphx,
guitsaru,
just1602 and
veganstraightedge
as code owners
Contributor
Author
|
@veganstraightedge @just1602 here are the color variables. after this, I'll do the comment syntax. The comments should be the last big multi-file change before moving on to converting the individual component files |
just1602
approved these changes
Mar 26, 2026
veganstraightedge
approved these changes
Apr 2, 2026
4 tasks
just1602
pushed a commit
that referenced
this pull request
Apr 14, 2026
# What are the relevant GitHub issues? related to this PR: #5212 # What does this pull request do? All of this is find/replace of SCSS comment syntax (`// comment`) with CSS comment syntax (`/* comment */`) # How should this be manually tested? - Just being able to load the site without a sass error is a good sign # Is there any background context you want to provide for reviewers? This is one PR in what will be an extended series of commits to eventually drop the css and js pre-processor gem dependencies as discussed in #5212 As referenced in the color variable PR ([#5223](#5223 (comment))), this should be the last PR in this series that touches many files at once. The next step is to convert each SCSS file to CSS files either file by file or in small groups where it make sense. # Questions for the pull request author (delete any that don't apply): - [ ] Are any needed README/wiki/documentation updates needed for this pull request? - [ ] Does the code you updated have tests? If not, could you add some please? - [ ] Does this pull request require any new server dependencies which need to be added to the build process? If so, please explain what. # Acceptance Criteria ## These should be checked by the reviewers - [x] This pull request does not cause the database export script to become out of sync with the db schema
4 tasks
Bargraph6
added a commit
to Bargraph6/website
that referenced
this pull request
Apr 20, 2026
What does this commit do =========================== Since the [conversion of the social icons from SCSS to CSS][0] has reached production and is working, we can move forward with renaming several `.scss` files to `.css`. **This is only a rename**. No changes are needed for these files as they already contains only CSS markup. There are other files that contain only CSS that need to be renamed. However, since they are larger files I will rename them in individual commits in case there is some SCSS syntax I missed. Changelog =========================== * 2017/articles_custom_css.css: This file is rather small, so it easy to see that it only contains CSS. I also tested this locally and it still works as a CSS file. * 2017/base/variables/_borders.scss: previously converted to css in [ba7c239][1]. Doing rename now as the social icons test worked in production. * 2017/base/variables/_colors.scss: previously converted to css in [eae7461][2]. Doing rename now as the social icons test worked in production. * 2017/components/_buttons.scss: With the previous commits to replace border and color SCSS variables with CSS variables done, this file now only contains CSS and can be renamed. * 2017/components/_colors.scss: This file is rather small, so it is easy to see that it only contains CSS. * 2017/components/_localization.scss: This file is very small (3 lines), so it is easy to see that it only contains CSS. * 2017/lib/_reset.scss: As referenced in the header comment, this file is a copy/paste of a CSS file. * 2017/lib/_utilities.scss: This file is very small (3 lines), so it is easy to see that it only contains CSS. --- related to: crimethinc#5212 related to: crimethinc#5259 related to: crimethinc#5223 related to: crimethinc#5216 [0]:crimethinc#5259 [1]:crimethinc@ba7c239 [2]:crimethinc@eae7461
1 task
just1602
pushed a commit
to Bargraph6/website
that referenced
this pull request
Apr 20, 2026
What does this commit do =========================== Since the [conversion of the social icons from SCSS to CSS][0] has reached production and is working, we can move forward with renaming several `.scss` files to `.css`. **This is only a rename**. No changes are needed for these files as they already contains only CSS markup. There are other files that contain only CSS that need to be renamed. However, since they are larger files I will rename them in individual commits in case there is some SCSS syntax I missed. Changelog =========================== * 2017/articles_custom_css.css: This file is rather small, so it easy to see that it only contains CSS. I also tested this locally and it still works as a CSS file. * 2017/base/variables/_borders.scss: previously converted to css in [ba7c239][1]. Doing rename now as the social icons test worked in production. * 2017/base/variables/_colors.scss: previously converted to css in [eae7461][2]. Doing rename now as the social icons test worked in production. * 2017/components/_buttons.scss: With the previous commits to replace border and color SCSS variables with CSS variables done, this file now only contains CSS and can be renamed. * 2017/components/_colors.scss: This file is rather small, so it is easy to see that it only contains CSS. * 2017/components/_localization.scss: This file is very small (3 lines), so it is easy to see that it only contains CSS. * 2017/lib/_reset.scss: As referenced in the header comment, this file is a copy/paste of a CSS file. * 2017/lib/_utilities.scss: This file is very small (3 lines), so it is easy to see that it only contains CSS. --- related to: crimethinc#5212 related to: crimethinc#5259 related to: crimethinc#5223 related to: crimethinc#5216 [0]:crimethinc#5259 [1]:crimethinc@ba7c239 [2]:crimethinc@eae7461
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant GitHub issues?
related to this PR: #5212
What does this pull request do?
Almost all of this is find/replace. The one additional change is in the
_colors.scssfile I removed an unused variable ($header-color-list)How should this be manually tested?
lighten/darkenfunction with css relative color syntax:Is there any background context you want to provide for reviewers?
This is one PR in what will be an extended series of commits to eventually drop the css and js pre-processor gem dependencies as discussed in #5212
This is very similar to the border size variables PR that was merged in #5216
Questions for the pull request author (delete any that don't apply):
Acceptance Criteria
These should be checked by the reviewers