feat: expose configurable gRPC max receive message size#136
Merged
bobh66 merged 2 commits intocrossplane-contrib:mainfrom Apr 30, 2026
Merged
feat: expose configurable gRPC max receive message size#136bobh66 merged 2 commits intocrossplane-contrib:mainfrom
bobh66 merged 2 commits intocrossplane-contrib:mainfrom
Conversation
Adds a --max-recv-message-size CLI flag (in MB, default 4) so users can raise the gRPC server limit when the function emits enough desired resources to exceed the default 4 MB cap, which otherwise causes XR reconciliation to fail with ResourceExhausted. Fixes crossplane-contrib#135 Signed-off-by: Christian Artin <gravufo@gmail.com>
d3a6746 to
b599fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--max-recv-message-sizeCLI flag (value in MB, default4) that is wired through tofunction.MaxRecvMessageSizefrom the function SDK. This lets operators raise the gRPC server's max receive size when the function emits enough desired resources to exceed the default 4 MB cap.When the deletion-ordering option is used on a sizeable pipeline,
function-sequencercan produce a large desired-state payload. Crossplane then fails XR reconciliation with:This matches the same flag added in
function-template-go#91and aligns with the discussions infunction-auto-ready#47,crossplane#6392, andfunction-sdk-go#194.Behavior
--max-recv-message-size(int, MB, default4) — preserves existing behavior when unset.1024 * 1024and passed tofunction.MaxRecvMessageSize.Testing
go build ./...go test ./...go vet ./...golangci-lint run ./...Fixes #135