Skip to content

fix: escape special_anchor in HtmlOutput JS string literal #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlkleinpaste merged 1 commit into from
Jun 30, 2026
Merged

fix: escape special_anchor in HtmlOutput JS string literal #1337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/gtk/utilities.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1299,11 +1299,21 @@ HtmlOutput(char *text, GtkWidget *gtkText, MOD_FONT *mf, char *anchor)
len -= offset;

// now write the javascript snippet.
// escape the anchor for safe interpolation into a JS
// string literal. special_anchor can originate from
// untrusted BibleSync navigation packets whose ref
// field carries the '#' fragment; without escaping a
// crafted value can break out of the string and inject
// script into the WebKit view.
const gchar *raw_anchor =
(settings.special_anchor ? settings.special_anchor : anchor);
gchar *esc_anchor = g_strescape(raw_anchor, NULL);
buf =
g_strdup_printf("<script type=\"text/javascript\" language=\"javascript\">"
" window.onload = function () { window.location.hash = \"%s\"; }"
" </script>",
(settings.special_anchor ? settings.special_anchor : anchor));
esc_anchor);
g_free(esc_anchor);
XIPHOS_HTML_WRITE(html, buf, strlen(buf));
g_free(buf);
}
Expand Down