fix: replace strcpy with g_strlcpy for module_name in sidebar#1338
Merged
karlkleinpaste merged 1 commit intoJun 30, 2026
Merged
Conversation
main_display_verse_list_in_sidebar() copies module_name into two fixed 80-byte buffers (settings.sb_search_mod[80] and sidebar.mod_name[80]) using strcpy() with no bounds check. When BibleSync navigation takes the indirect path (unknown module, multi-ref, or user preference), the bible field from the UDP packet is passed directly as module_name at biblesync_glue.cc:184. A bible field exceeding 80 bytes overflows both global buffers. Replace strcpy with g_strlcpy, which always null-terminates and never writes more than the specified buffer size.
Contributor
|
I am perversely impressed by the wide variety of such things you're finding to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main_display_verse_list_in_sidebar() in src/main/sidebar.cc copies module_name into two fixed 80-byte buffers (settings.sb_search_mod[80] and sidebar.mod_name[80]) using strcpy() with no length check.
When BibleSync navigation takes the indirect path (unknown module name, multi-verse reference, or user preference for indirect navigation), the bible field from the UDP packet is passed directly as module_name at biblesync_glue.cc:184. A bible field exceeding 80 bytes overflows both global buffers, corrupting adjacent fields in the SETTINGS and SIDEBAR structs.
The fix replaces both strcpy() calls with g_strlcpy(), which always null-terminates and never writes more than the specified buffer size.