Conversation
I updated the template by using the latest version of the orignial template
changed a few things so the r template is closer to the original
There was a problem hiding this comment.
Hi Henry, thanks, this is great. The added detail in the description of the items will be very helpful, especially the examples. I have added some comments and requested a few changes. Would you be willing to revise your PR?
Also, before we merge your changes, you may consider adding yourself as a contributor to the DESCRIPTION file.
-I have implemented the comments -Required → * -Errors fixed
vantveer prereg -Comments implemented -Required → *
update to the latest as predicted_prereg version Some formatting changes to ensure consistency with the other templates
I changed <-- to <!--
I forgot to add a few exclamation marks in the code
new template suggestion
new template suggestion
new template suggestion
new template suggestion
new template suggestion
new template suggestion
added the latest version of the prp quant template
|
This pull request implements the requested comments and fixes remaining errors. |
formatting changes
i -> 1 ii -> 2 etc.
crsh
left a comment
crsh
left a comment
There was a problem hiding this comment.
Thanks for this. I have added some more comments.
For the newly added templates (e.g., QRP-QUANT), please make sure that the folder structure is analogous to those of the other templates. Specifically:
- Each template needs to go into a subfolder of
inst/rmarkdown/templates, these should be in all lower case and adhere to the conventions of previous templates. For example for the EEG-template: `eeg_erp_prereg`` - The template files themselves should be names
skeleton.Rmd
inst/rmarkdown/templates/Preregistration of Multiverse Analyses
Outdated
Show resolved
Hide resolved
inst/rmarkdown/templates/Preregistration of Multiverse Analyses
Outdated
Show resolved
Hide resolved
…nst/rmarkdown/templates/eeg_erg_prereg/skeleton.Rmd
…markdown/templates/eeg_erg_prereg/skeleton/skeleton.Rnd
…tes/prp_quant_v3_prereg/skeleton/skeleton.Rmd
…/templates/prereg_exp_sampling/skeleton/skeleton.Rmd
…Reviews to inst/rmarkdown/templates/scoping_reviews_prereg/skeleton/skeleton.Rmd
…s to inst/rmarkdown/templates/multi_analyses_prereg/skeleton/skeleton.Rmd
…lysis: A template to inst/rmarkdown/templates/secondary_data_analysis_prereg/skeleton/skeleton.Rmd
… to inst/rmarkdown/templates/qualitative_study_prereg/skeleton/skeleton.Rmd
removed chunk and formatting changes
chunk removed # formatting changes
implemented commets
implemented the comments
implemented comments
implemented comments
implemented comments(not all of them yet)
|
I implemented most of the suggestions. I still need to change the numbering to level-3 headings in the exp_sampling_prereg template. In addition, I will double-check that the formatting is consistent across all templates. |
formatting changes
Enter your response here was missing
deleted: ## Working Title Enter your response here. because the title is supposed to be on the front page
I am not sure what this part does there so I deleted it
formatting changes
|
Great, thanks. @LisaSpitzer would be willing to review the implementation of the PRP-QUANT before I merge this? |
crsh
left a comment
crsh
left a comment
There was a problem hiding this comment.
Thanks Henry, there is a bit of formatting of the Markdown left to do, but I think it will be quicker if I do this myself.
2 participants
I updated the templates so they are more similar to the originals