Fix: Add null check for new_owner_address in NFT transfer#152
Open
prjanitor wants to merge 1 commit into
Open
Conversation
Validates that new_owner_address is not None before proceeding with the transfer body creation. This prevents write_address from being called with None when both response_address and new_owner_address are None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a null pointer vulnerability in
NFTItem.create_transfer_body()where thenew_owner_addressparameter could beNone, causingwrite_address(None)to be called and potentially write invalid data or fail.Changes
create_transfer_body()to check ifnew_owner_addressisNoneValueErrorwith descriptive message if validation failsTesting
The fix ensures that calling
create_transfer_body()withnew_owner_address=Nonewill raise a clear error rather than silently writing invalid data to the cell.Related
Fixes bug #257: Missing null check for response_address in NFT transfer
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.