Skip to content

[WIP] Refactor CrystaTask to service interface and add test fakes #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afshinalizadeh merged 3 commits into from
Dec 12, 2025
Merged

[WIP] Refactor CrystaTask to service interface and add test fakes #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58534af
Initial plan
Copilot Dec 12, 2025
83d8c8e
Fix CrystaTaskServiceFake query logic and SyncInfo population per cod…
Copilot Dec 12, 2025
bc75731
Simplify GetWorkItemSyncItemsAsync to directly assign SyncInfo
Copilot Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/CrystaLearn.Core/Services/CrystaProgramSyncModuleServiceFake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public partial class CrystaProgramSyncModuleServiceFake : ICrystaProgramSyncModu
{
private static List<CrystaProgramSyncModule> _modules = new();

private IConfiguration Configuration { get; set; } = default!;
private IConfiguration Configuration { get; set; } = default!;

public CrystaProgramSyncModuleServiceFake(IConfiguration configuration)
{
Expand Down
35 changes: 14 additions & 21 deletions src/Core/CrystaLearn.Core/Services/CrystaTaskServiceFake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,29 +95,22 @@ public Task<int> DeleteCrystaTaskUpdatesAsync(List<string> syncIds)

public Task<List<string>> GetAllWorkItemSyncIdsAsync(string project)
{
var ids = _tasks
.Where(t => !string.IsNullOrEmpty(t.ProviderTaskId))
.Select(t => t.ProviderTaskId!)
// Get all non-deleted tasks sync IDs matching the project
var syncIds = _tasks
.Where(t => !t.IsDeleted && t.ProjectName == project && !string.IsNullOrEmpty(t.WorkItemSyncInfo.SyncId))
.Select(t => t.WorkItemSyncInfo.SyncId ?? "")
.Where(id => !string.IsNullOrEmpty(id))
.ToList();

// If project filtering is required and CrystaProgram contains project name, filter.
if (!string.IsNullOrEmpty(project))
{
ids = _tasks
.Where(t => t.CrystaProgram != null && string.Equals(t.CrystaProgram.ToString(), project, StringComparison.OrdinalIgnoreCase) && !string.IsNullOrEmpty(t.ProviderTaskId))
.Select(t => t.ProviderTaskId!)
.ToList();
}

return Task.FromResult(ids);
return Task.FromResult(syncIds);
}

public Task<List<SyncItem>> GetCommentsSyncItemsAsync(List<string> ids)
{
if (ids == null || ids.Count == 0) return Task.FromResult(new List<SyncItem>());
var found = _comments
.Where(c => (c.Revision != null && ids.Contains(c.Revision)) || (c.ProviderTaskId != null && ids.Contains(c.ProviderTaskId)) || (c.Id != Guid.Empty && ids.Contains(c.Id.ToString())))
.Select(c => new SyncItem { Id = c.Id })
.Where(c => c.SyncInfo != null && ids.Contains(c.SyncInfo.SyncId ?? ""))
.Select(c => new SyncItem { Id = c.Id, SyncInfo = c.SyncInfo })
.ToList();
return Task.FromResult(found);
}
Expand All @@ -126,8 +119,8 @@ public Task<List<SyncItem>> GetRevisionsSyncItemsAsync(List<string> ids)
{
if (ids == null || ids.Count == 0) return Task.FromResult(new List<SyncItem>());
var found = _revisions
.Where(r => (r.Revision != null && ids.Contains(r.Revision)) || (r.ProviderTaskId != null && ids.Contains(r.ProviderTaskId)) || (r.Id != Guid.Empty && ids.Contains(r.Id.ToString())))
.Select(r => new SyncItem { Id = r.Id })
.Where(r => ids.Contains(r.WorkItemSyncInfo.SyncId ?? ""))
.Select(r => new SyncItem { Id = r.Id, SyncInfo = r.WorkItemSyncInfo })
.ToList();
return Task.FromResult(found);
}
Expand All @@ -136,8 +129,8 @@ public Task<List<SyncItem>> GetUpdatesSyncItemsAsync(List<string> ids)
{
if (ids == null || ids.Count == 0) return Task.FromResult(new List<SyncItem>());
var found = _updates
.Where(u => (u.Revision != null && ids.Contains(u.Revision)) || (u.ProviderTaskId != null && ids.Contains(u.ProviderTaskId)) || (u.Id != Guid.Empty && ids.Contains(u.Id.ToString())))
.Select(u => new SyncItem { Id = u.Id })
.Where(u => u.SyncInfo != null && ids.Contains(u.SyncInfo.SyncId ?? ""))
.Select(u => new SyncItem { Id = u.Id, SyncInfo = u.SyncInfo })
.ToList();
return Task.FromResult(found);
}
Expand All @@ -146,8 +139,8 @@ public Task<List<SyncItem>> GetWorkItemSyncItemsAsync(List<string> ids)
{
if (ids == null || ids.Count == 0) return Task.FromResult(new List<SyncItem>());
var found = _tasks
.Where(t => (t.ProviderTaskId != null && ids.Contains(t.ProviderTaskId)) || (t.Id != Guid.Empty && ids.Contains(t.Id.ToString())))
.Select(t => new SyncItem { Id = t.Id })
.Where(t => ids.Contains(t.WorkItemSyncInfo.SyncId ?? ""))
.Select(t => new SyncItem { Id = t.Id, SyncInfo = t.WorkItemSyncInfo })
.ToList();
return Task.FromResult(found);
}
Expand Down