Fix workflow dir refresh for reloaded hooks#19
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Agentic-Worker <cskwork@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Hooks now receive
SYMPHONY_WORKFLOW_DIR, but long-running orchestrators only refreshed hook scripts when the workflow reloaded with the sameworkspace.root. If the workflow file's resolved parent changed (for example, a stable workflow symlink was retargeted), future hooks kept receiving the old host repo path and could symlink or mutate the wrong tree.Root cause
WorkspaceManager.update_hooks()only updatedHooksConfig; the orchestrator did not propagatecfg.workflow_path.parentunless the workspace root changed and the manager was rebuilt.Fix
WorkspaceManager.update_hooks()to refresh the workflow directory alongside hooks.cfg.workflow_path.parentthrough the hot-reload path.Validation
python3 -m pytest tests/test_orchestrator_dispatch.py tests/test_workspace.py-> 18 passedPATH=<tmp python alias>:$PATH python3 -m pytest-> 193 passed, 2 skipped, 1 warningNote: the first plain full-suite run failed only because this container lacks a
pythonexecutable while one doctor test expectspython -m symphony.mock_codex; rerunning with a temporarypython -> python3alias passed.