Add hair effects #18
Open
Add hair effects #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiedt
requested changes
Sep 14, 2020
Owner
ctiedt
left a comment
ctiedt
left a comment
There was a problem hiding this comment.
Please add ios/Flutter/flutter_export_environment.sh to the gitignore as well.
Comment on lines
+34
to
+37
| shaderCallback: (Rect bounds) { | ||
| return ImageShader(snapshot.data, TileMode.clamp, TileMode.clamp, | ||
| Matrix4.identity().storage); | ||
| }, |
| import 'dart:ui' as ui; | ||
| import 'dart:async'; | ||
|
|
||
| class ImageMerger extends StatelessWidget { |
Owner
There was a problem hiding this comment.
A class comment would be helpful. You should also rename this class to make it more obvious that it is a widget.
| if (snapshot.hasData) { | ||
| return ShaderMask( | ||
| blendMode: blendMode, | ||
| child: Container(child: blendedWidget), |
Owner
There was a problem hiding this comment.
This Container can probably be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add rainbow and galaxy hair effect