Open
Conversation
Codecov Report
@@ Coverage Diff @@
## development #107 +/- ##
===============================================
+ Coverage 97.59% 97.63% +0.03%
===============================================
Files 33 33
Lines 415 422 +7
===============================================
+ Hits 405 412 +7
Misses 10 10
Continue to review full report at Codecov.
|
mori-atsushi
force-pushed
the
96-fix-unsubscribe
branch
from
708f5a6 to
2641f75
Compare
euglena1215
reviewed
May 1, 2019
app/models/user_room_log.rb
Outdated
| after_update :send_exit_message, if: proc { |log| log.exit_at_before_last_save.blank? && log.exit_at.present? } | ||
|
|
||
| scope :online, -> { where exit_at: nil } | ||
| scope :online, -> { where(exit_at: nil).where("updated_at > ?", Time.now.utc - 60 * 60) } |
Collaborator
There was a problem hiding this comment.
Suggested change
| scope :online, -> { where(exit_at: nil).where("updated_at > ?", Time.now.utc - 60 * 60) } | |
| scope :online, -> { where(exit_at: nil).where(updated_at: 1.hour.ago..Time.current) } |
euglena1215
reviewed
May 1, 2019
spec/models/user_room_log_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| context "when exit_at exsit" do |
Collaborator
There was a problem hiding this comment.
Suggested change
| context "when exit_at exsit" do | |
| context "when exit_at exist" do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
action cableでunsubscribeが呼ばれない場合がある
通信時にroom_user_logのupdated_atを更新し、それによってonlnieに表示するかしないか切り替えるようにした
懸念点