Support return statement type inference with merge vertex pattern#29
Merged
Support return statement type inference with merge vertex pattern#29
Conversation
Previously, method return types were inferred only from the last expression in the method body. This missed explicit `return` statements, causing false positives when a method used early returns with different types (e.g., `return "" if error; 42`). Introduce a merge vertex per method scope that collects types from both explicit `return` values and the implicit last-expression return, producing a union type for accurate method signature inference.
dak2
force-pushed
the
return-statement-type-inference
branch
from
f38e623 to
0ec147f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, method return types were inferred only from the last expression in the method body. This missed explicit
returnstatements, causing false positives when a method used early returns with different types (e.g.,return "" if error; 42).Introduce a merge vertex per method scope that collects types from both explicit
returnvalues and the implicit last-expression return, producing a union type for accurate method signature inference.