Support class method type registration and checking#32
Merged
Conversation
Class methods defined with `def self.foo` were silently ignored during type checking because they were registered as instance methods instead of singleton methods. This caused false negatives where type errors on class method return values went undetected.
dak2
force-pushed
the
class-method-support
branch
from
2d8deee to
edd2e69
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class methods defined with
def self.foowere silently ignored during type checking because they were registered as instance methods instead of singleton methods. This caused false negatives where type errors on class method return values went undetected.