Remove stateless Analyzer class and simplify Ruby FFI surface#33
Merged
Conversation
Analyzer was a stateless wrapper — its `path` field was unused (#[allow(dead_code)]) and `infer_types` never referenced `self`. Users interact only via CLI (`methodray check`), never via `require 'methodray'`, so there is no need for a public Ruby class. - Delete Analyzer struct/impl and version() (duplicated in CLI) - Convert infer_types to a public module function on MethodRay - Auto-execute setup() in #[magnus::init] instead of exposing it - Simplify checker.rs error messages (remove stale Analyzer references) - Update release.yml cache generation to use implicit require trigger Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analyzer was a stateless wrapper — its
pathfield was unused (#[allow(dead_code)]) andinfer_typesnever referencedself. Users interact only via CLI (methodray check), never viarequire 'methodray', so there is no need for a public Ruby class.