Skip to content

Update Gemfile.lock#20

Open
danMateer wants to merge 2 commits intomasterfrom
release-1.2.12
Open

Update Gemfile.lock#20
danMateer wants to merge 2 commits intomasterfrom
release-1.2.12

Conversation

@danMateer
Copy link
Copy Markdown
Owner

No description provided.

Copy link
Copy Markdown

@staging staging Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network.


Check the status or cancel PullRequest code review here - or - cancel by adding [!pr] to the title of the pull request.

Copy link
Copy Markdown

@staging staging Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 0
- 0

Generated lines of change

+ 2
- 2

Type of change

Minor Update - These changes appear to be a minor update to existing functionality and features.
1 Message
📚 It looks like the description for this pull request is either blank or very short. Adding a high-level summary will help our reviewers provide better feedback. Feel free to include questions for PullRequest reviewers and make specific feedback requests.

Copy link
Copy Markdown

@staging staging Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the RFC allows for the specification of absolute paths e.g. GET https://hackerone.com/foo/bar HTTP/1.1, if this is not supported we should consider verifying that the relative path is a valid relative path (i.e. starts with /) or failing if invalid

Image of Chanse T Chanse T


Reviewed with ❤️ by PullRequest

Comment thread Gemfile.lock
octokit (4.14.0)
sawyer (~> 0.8.0, >= 0.5.3)
omniauth (1.9.0)
omniauth (1.9.2)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up the RFC allows for absolute paths. we need to verify the path is valid?

🔺 Bug (Critical)

Image of Chanse T Chanse T

Copy link
Copy Markdown

@staging staging Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to inactivity, PullRequest has cancelled this review job. You can reactivate the code review job from the PullRequest dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant