http_build_query incorrectly encodes spaces#8
Open
MichaelApproved wants to merge 1 commit intodancameron:masterfrom
Open
http_build_query incorrectly encodes spaces#8MichaelApproved wants to merge 1 commit intodancameron:masterfrom
MichaelApproved wants to merge 1 commit intodancameron:masterfrom
Conversation
The http_build_query will encode a space as a plus sign. This should be encoded as %20, instead of "+". Encoding as a + will cause Google Analytics to display it as a plus sign. By manually building the query string, we can use rawurlencode to do proper encoding of spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The http_build_query will encode a space as a plus sign. This should be encoded as %20, instead of "+". Encoding as a + will cause Google Analytics to display it as a plus sign.
By manually building the query string, we can use rawurlencode to do proper encoding of spaces.