fix(pool): pool probe works for Mac remotes — zsh glob + mem fallback#11
Merged
Conversation
…back
Registering `mini` (an Apple Silicon Mac) to the pool surfaced two
Linux-only assumptions in _probe_remote that crashed `pool probe`:
1. zsh unmatched-glob crash — the remote GPU probe runs
`ls /sys/class/drm/card*/device/vendor`. A Mac remote's login shell
is zsh, which aborts the command line on an unmatched glob ("no
matches found"), killing the whole probe script and poisoning the
cores/mem parse (`to_int: not an integer: "zsh:1: no matches…"`).
Fix: prefix the remote script with `setopt nonomatch 2>/dev/null;` —
zsh then passes an unmatched glob literally (`ls` → 2>/dev/null →
empty); bash/sh have no `setopt` (error suppressed) and already pass
unmatched globs literally, so it is harmless there.
2. mem reported 0 MB — memory detection only read /proc/meminfo (Linux).
Fix: fall back to `sysctl -n hw.memsize` on Mac, mirroring the cores
line's existing `nproc || sysctl hw.ncpu` dual path.
Verified: wilson build OK; wilson test 23/23; `pool probe` now reports
all 4 hosts — mac, ubu-1 (gpu=NVIDIA), ubu-2, and mini (Darwin 25.4.0
arm64, 10 cores, 16384 MB). Before: mini → zsh-glob crash / 0 MB.
Done via the `worktree` plugin (worktree start→pr→merge→finish in /tmp).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering mini (Apple Silicon Mac) surfaced 2 Linux-only assumptions in _probe_remote that crashed pool probe: (1) zsh aborts on the unmatched /sys/class/drm/card* GPU-probe glob — fixed with setopt nonomatch; (2) mem read only /proc/meminfo — added sysctl hw.memsize fallback. wilson test 23/23; pool probe now reports all 4 hosts incl mini (Darwin, 10c, 16384MB). Done via the worktree plugin.