Merged
Conversation
Renamed variables for consistency and clarity in EchoServer. Improved connection counting and locking in WebSocketServer, removed unnecessary async void usage, and moved connection management logic to use proper locking. Added disposal flags to prevent double disposal in Connection and WebSocketServer. Updated FrameHeaders XML comments and refactored payload length check for readability.
Disabled the Console.WriteLine statement in the OnFrame event handler to reduce console output, for cleaner logs or performance reasons.
Removed unnecessary comments from WebSocketServer.cs for cleaner code. Updated OpCode enum in Framing to explicitly use byte as the underlying type for clarity and protocol compliance.
Replaced the for-loop with Array.Fill to initialize the masking key array, improving code readability and conciseness.
Changed the target framework from net6.0 to net9.0 in both Sox.EchoServer and Sox.Tests projects to support the latest .NET features and improvements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.