fix: stop verifying fingerprint in bobProcessQr (issue #313 stage 1)#315
Merged
Conversation
Make QrPayload.fingerprint optional (String? = null); remove the fingerprint consistency check in bobProcessQr and its corresponding test. Alice still sends the field for backwards compatibility. key_confirmation remains the authoritative integrity check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #313 (stage 1).
Summary
QrPayload.fingerprint→String? = null(optional in JSON; Alice still sends it for backwards compatibility)bobProcessQr—key_confirmationis the authoritative integrity checkbobProcessQr rejects tampered fingerprinttest.lengthcall in the Alice-side QR payload testTest plan
./gradlew :shared:jvmTestpasses🤖 Generated with Claude Code