Skip to content

Port MCP editor pane parity to main#347

Open
danshapiro wants to merge 5 commits into
mainfrom
codex/mcp-editor-main-parity
Open

Port MCP editor pane parity to main#347
danshapiro wants to merge 5 commits into
mainfrom
codex/mcp-editor-main-parity

Conversation

@danshapiro
Copy link
Copy Markdown
Owner

Summary

  • Port the dev MCP guidance updates so split-pane defaults to left/right and text files prefer editor panes.
  • Port editor line-wrap support with wordWrap persistence through pane content, snapshots, and server-created editor panes.
  • Stabilize the PaneContainer lazy editor test and escape MCP inline code so the main-based branch typechecks.

Tests

  • FRESHELL_TEST_SUMMARY="codex mcp editor main parity focused tests" npm run test:vitest -- test/integration/client/editor-pane.test.tsx test/unit/client/components/panes/EditorPane.test.tsx test/unit/client/components/panes/PaneContainer.test.tsx
  • FRESHELL_TEST_SUMMARY="codex mcp editor main parity split and persistence tests" npm run test:vitest -- test/unit/server/mcp/freshell-tool.test.ts test/server/agent-panes-write.test.ts test/unit/server/agent-layout-store-write.test.ts test/unit/server/agent-layout-store.test.ts test/unit/client/components/panes/PaneLayout.test.tsx test/unit/client/lib/tab-registry-snapshot.test.ts test/unit/client/store/panesPersistence.test.ts
  • FRESHELL_TEST_SUMMARY="codex mcp editor main parity server split tests" npm run test:vitest -- --config vitest.server.config.ts test/unit/server/mcp/freshell-tool.test.ts test/server/agent-panes-write.test.ts test/unit/server/agent-layout-store-write.test.ts test/unit/server/agent-layout-store.test.ts
  • npm run typecheck
  • npm run build

Note: the second command only exercised the default client Vitest config for the client-side paths; the server paths were covered by the following server-config command.

Dan Shapiro added 5 commits May 17, 2026 23:38
…files

- Add instruction that split-pane defaults to vertical (left/right) panes
- Expand editor pane guidance: use editor for any text file with syntax
  highlighting; reserve terminals for interactive commands only
- Update HELP_TEXT direction docs to clarify horizontal=top/bottom,
  vertical=left/right
- Fix pre-existing escaped backtick build error in template literals

(cherry picked from commit 1a9066e)
- Add WrapText button to EditorToolbar with wordWrap state
- Monaco editor defaults to wordWrap: 'on'
- Toggle button uses secondary variant when wrap is on
- Add WrapText to lucide-react mocks in affected tests

(cherry picked from commit 4c0b8b9)
Fresheyes review fixes:
- MCP docs had direction backwards; horizontal=left/right (flex-row),
  vertical=top/bottom (flex-col). Fixed INSTRUCTIONS and HELP_TEXT.
- Changed REST API default direction from vertical to horizontal so
  split-pane defaults to left/right (user request).
- wordWrap is now part of EditorPaneContent and persisted through
  Redux, localStorage, and tab-registry snapshots.
- Added EditorPane tests for wrap toggle rendering and defaults.
- Added PaneContainer test verifying wordWrap Redux dispatch.

(cherry picked from commit 6137c7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant