Port multi-row tabs setting to main#356
Open
danshapiro wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/main.multirowTabslocal pane setting, Settings > Panes toggle, local browser-preferences persistence, wrapped TabBar layout, and docs mock CSS.Source and scope
00a54902bb88c25c04dc7e49e2200188377e9f31(feat: add multi-row tabs setting (per-client, off by default)).TabBar.tsxconflict, this port preserved currentmainsidebar reopen placement instead of pulling in the unrelateddevparent change that had moved it outside the tab scroller.multirowTabs.Verification
npm run test:vitest -- test/unit/shared/settings.test.ts test/unit/client/store/browserPreferencesPersistence.test.ts test/unit/client/components/TabBar.multirow.test.tsx --runpassed: 3 files, 43 tests.npm run typecheck:clientpassed.npm run build:clientpassed, with existing Vite dynamic-import and chunk-size warnings.npm run lintpassed with 14 existing warnings and 0 errors.npm run typecheck:serverfailed before this branch's touched code due to existingorigin/mainparse errors inserver/mcp/freshell-tool.tslines 73 and 472.npm run build:serverfailed on the same existing parse errors.npm run test:e2e:chromium -- test/e2e-browser/specs/multirow-tabs.spec.tswas blocked in global setup because it runsnpm run build:client && npm run build:server, andbuild:serverfails on the same existing parse errors.Supersedes
This PR supersedes the #335 multi-row tabs setting payload currently embedded in stale #342.