Limit server console logs to errors#360
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2fdaf8a047
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const shouldPrettyPrint = env !== 'production' && env !== 'test' | ||
| const consoleStream = createConsoleStream(shouldPrettyPrint) | ||
| const consoleLogger = pino(createPinoOptions(), consoleStream) | ||
| const consoleLogger = pino(createPinoOptions({ level: DEFAULT_CONSOLE_LOG_LEVEL }), consoleStream) |
There was a problem hiding this comment.
Preserve debug-stream failure warnings on console
Setting consoleLogger to error here suppresses all consoleLogger.warn(...) calls from attachDebugStreamWarnings, including runtime warning/error events emitted by rotating-file-stream. In that failure mode the debug log stream can degrade or stop, but operators get no console signal because those warnings are filtered out; this is a regression from the previous behavior where these diagnostics were visible.
Useful? React with 👍 / 👎.
Summary
Test Plan