Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-125
to
+127
| rules = component.get("rules", None) | ||
| if rules: | ||
| if rules := component.get("rules", None): | ||
| self[name].ruler.enableOnly(rules) | ||
| rules2 = component.get("rules2", None) | ||
| if rules2: | ||
| if rules2 := component.get("rules2", None): |
Author
There was a problem hiding this comment.
Function MarkdownIt.configure refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-108
to
+113
| result = "" | ||
|
|
||
| for i, token in enumerate(tokens): | ||
| if token.type in self.rules: | ||
| result += self.rules[token.type](tokens, i, options, env) | ||
| else: | ||
| result += self.renderToken(tokens, i, options, env) | ||
|
|
||
| return result | ||
| return "".join( | ||
| self.rules[token.type](tokens, i, options, env) | ||
| if token.type in self.rules | ||
| else self.renderToken(tokens, i, options, env) | ||
| for i, token in enumerate(tokens) | ||
| ) |
Author
There was a problem hiding this comment.
Function RendererHTML.renderInline refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Use str.join() instead of for loop (
use-join) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-164
to
+172
| if token.nesting == 1: | ||
| if idx + 1 < len(tokens): | ||
| nextToken = tokens[idx + 1] | ||
| if token.nesting == 1 and idx + 1 < len(tokens): | ||
| nextToken = tokens[idx + 1] | ||
|
|
||
| if nextToken.type == "inline" or nextToken.hidden: | ||
| # Block-level tag containing an inline tag. | ||
| # | ||
| needLf = False | ||
| if nextToken.type == "inline" or nextToken.hidden: | ||
| # Block-level tag containing an inline tag. | ||
| # | ||
| needLf = False | ||
|
|
||
| elif nextToken.nesting == -1 and nextToken.tag == token.tag: | ||
| # Opening tag + closing tag of the same type. E.g. `<li></li>`. | ||
| # | ||
| needLf = False | ||
| elif nextToken.nesting == -1 and nextToken.tag == token.tag: | ||
| # Opening tag + closing tag of the same type. E.g. `<li></li>`. | ||
| # | ||
| needLf = False |
Author
There was a problem hiding this comment.
Function RendererHTML.renderToken refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
Comment on lines
-185
to
+184
| result = "" | ||
|
|
||
| for key, value in token.attrItems(): | ||
| result += " " + escapeHtml(key) + '="' + escapeHtml(str(value)) + '"' | ||
|
|
||
| return result | ||
| return "".join( | ||
| f' {escapeHtml(key)}' + '="' + escapeHtml(str(value)) + '"' | ||
| for key, value in token.attrItems() | ||
| ) |
Author
There was a problem hiding this comment.
Function RendererHTML.renderAttrs refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Use str.join() instead of for loop (
use-join) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-224
to
+220
| return ( | ||
| "<code" | ||
| return (("<code" | ||
| + self.renderAttrs(token) | ||
| + ">" | ||
| + escapeHtml(tokens[idx].content) | ||
| + "</code>" | ||
| ) | ||
| + ">" + escapeHtml(token.content)) + "</code>") |
Author
There was a problem hiding this comment.
Function RendererHTML.code_inline refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable)
Comment on lines
-79
to
+76
| if scheme in RECODE_HOSTNAME_FOR: | ||
| url = urlunparse( | ||
| return urlunparse( |
Author
There was a problem hiding this comment.
Function normalizeLink refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-129
to
+121
| if scheme in RECODE_HOSTNAME_FOR: | ||
| url = urlunparse( | ||
| return urlunparse( |
Author
There was a problem hiding this comment.
Function normalizeLinkText refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable) - Replace if statement with if expression (
assign-if-exp)
| if c >= 0xFDD0 and c <= 0xFDEF: | ||
| return False | ||
| if ((c & 0xFFFF) == 0xFFFF) or ((c & 0xFFFF) == 0xFFFE): | ||
| if c & 0xFFFF in [0xFFFF, 0xFFFE]: |
Author
There was a problem hiding this comment.
Function isValidEntityCode refactored with the following changes:
- Replace multiple comparisons of same variable with
inoperator (merge-comparisons)
|
|
||
| ESCAPABLE = r"""\\!"#$%&'()*+,./:;<=>?@\[\]^`{}|_~-""" | ||
| ESCAPE_CHAR = re.compile(r"\\([" + ESCAPABLE + r"])") | ||
| ESCAPE_CHAR = re.compile(f'\\\\([{ESCAPABLE}])') |
Author
There was a problem hiding this comment.
Lines 153-153 refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| def escapeRE(string: str) -> str: | ||
| string = REGEXP_ESCAPE_RE.sub("\\$&", string) | ||
| return string | ||
| return REGEXP_ESCAPE_RE.sub("\\$&", string) |
Author
There was a problem hiding this comment.
Function escapeRE refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
xinrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
xinbranch, then run:Help us improve this pull request!