Skip to content

Conversation

@TurboGit
Copy link
Member

@TurboGit TurboGit commented Jan 5, 2026

  • Fix HDR semantic in auto-presets.

    If HDR is ticked : match all images including the HDR ones.
    If HDR is not ticked : match all images except the HDR ones.

  • Another instance of preset filter migrated.

    Use also dt_presets_get_filter to ensure consistency.

If HDR is ticked     : match all images including the HDR ones.
If HDR is not ticked : match all images except the HDR ones.
Use also dt_presets_get_filter to ensure consistency.
@TurboGit TurboGit added this to the 5.4.1 milestone Jan 5, 2026
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. labels Jan 5, 2026
@TurboGit TurboGit force-pushed the po/more-preset-fixes branch 2 times, most recently from 9f8792e to db92aed Compare January 5, 2026 09:20
@victoryforce
Copy link
Collaborator

  • If HDR is ticked : match all images including the HDR ones.

In other words, if HDR is checked, it will be interpreted as no-op. For me, this is unexpected semantics, and also inconsistent with other checkboxes.

@TurboGit
Copy link
Member Author

TurboGit commented Jan 5, 2026

In other words, if HDR is checked, it will be interpreted as no-op. For me, this is unexpected semantics, and also inconsistent with other checkboxes.

Agreed, this is not consistent but the consistent implementation/semantic does break most (if not all) current auto-presets. So for 5.4.1 this PR is needed. Then we can revisit the semantic for 5.6 and possibly adding more controls to users when creating a preset.

@jenshannoschwalm
Copy link
Collaborator

Still i think the agx auto-applied preset should be for raws as we have for sigmoid/filmicrgb.

@AxelG-DE
Copy link

AxelG-DE commented Jan 5, 2026

@gi-man guided me here, but a quick glance over the discussions I am not sure here is the right place (I am sorry, currently concentrating on something totally different...)

I am on darktable 5.5.0+57~ge72950bee5 and have the issue, that my auto-presets do not auto-apply anymore, such like:
for my olympus the following auto-applied things did not happen:

  • crop 3:2
  • lens correction
  • denoise when lower than ISO400 (a little strength of 0.4)

@TurboGit TurboGit merged commit 65fe2e9 into master Jan 5, 2026
14 of 16 checks passed
@TurboGit TurboGit deleted the po/more-preset-fixes branch January 5, 2026 11:58
@AxelG-DE
Copy link

AxelG-DE commented Jan 5, 2026

quick.test with 5.5.0+61~g65fe2e9e3a

all auto-appied things worked THANKS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants