Skip to content

Traditional Chinese language update#320

Open
jimmyorz wants to merge 1 commit into
darrylmorley:mainfrom
jimmyorz:main
Open

Traditional Chinese language update#320
jimmyorz wants to merge 1 commit into
darrylmorley:mainfrom
jimmyorz:main

Conversation

@jimmyorz

@jimmyorz jimmyorz commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Improve translation consistency and refine updated strings.

Summary by CodeRabbit

  • Documentation
    • Improved Traditional Chinese translations for display diagnostics, with clarified wording on monitor resolution and refresh rate capabilities.
    • Enhanced explanations for display quality and optimization features in Traditional Chinese language.

Improve translation consistency and refine updated strings.
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5b6c4d60-6a36-4bcd-ad18-58c8321ee6d8

📥 Commits

Reviewing files that changed from the base of the PR and between f337322 and 1af70a0.

📒 Files selected for processing (1)
  • Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings

📝 Walkthrough

Walkthrough

Updated Traditional Chinese translations in Localizable.strings for display diagnostics. Two tooltips were refined: one now explicitly references the monitor's "supported maximum" resolution and refresh, and the other clarifies that the link carries the display's top mode while updating the DSC limitation and full quality statements.

Changes

Display Diagnostics Translation Refinements

Layer / File(s) Summary
Display diagnostics tooltip and message rewording
Sources/WhatCableCore/Resources/zh-Hant.lproj/Localizable.strings
Two Traditional Chinese translation improvements: the link resolution/refresh tooltip now explicitly states the monitor's "supported maximum" capabilities, and the top mode/full quality message is rephrased to clarify link mode description and update DSC limitation and full quality phrasing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • darrylmorley/whatcable#255: Both PRs modify the same Traditional Chinese localization strings for display diagnostics tooltips and DSC wording.
  • darrylmorley/whatcable#305: Both PRs update Traditional Chinese display-diagnostics strings in Localizable.strings for link/mode/quality related messaging.
  • darrylmorley/whatcable#235: Both PRs update Traditional Chinese Localizable.strings in WhatCableCore's display diagnostics text area.

Poem

🐰 A whisker-twitch of text so fine,
Traditional phrases realigned,
"Monitor's maximum" shines through,
Top mode clarity, DSC too! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Traditional Chinese language update' accurately describes the main change—updating Traditional Chinese translations in the Localizable.strings file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant