Skip to content

chore: unify and fix analysis options across packages#528

Open
kevmoo wants to merge 5 commits into
masterfrom
fix_analyzer
Open

chore: unify and fix analysis options across packages#528
kevmoo wants to merge 5 commits into
masterfrom
fix_analyzer

Conversation

@kevmoo

@kevmoo kevmoo commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Bump min SDK of pkg:shelf to Dart 3.9

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the analysis options by adding the "simple_directive_paths" and "unnecessary_ignore" rules, removing redundant local "analysis_options.yaml" files, and deleting obsolete ignore comments. It also adjusts "await" usages in tests. The review feedback suggests simplifying "return await webSocket.close();" to "await webSocket.close();" in "web_socket_test.dart" for cleaner and more idiomatic asynchronous code.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pkgs/shelf_web_socket/test/web_socket_test.dart
Comment thread pkgs/shelf_web_socket/test/web_socket_test.dart
Comment thread pkgs/shelf_web_socket/test/web_socket_test.dart
@github-actions github-actions Bot added the type-infra A repository infrastructure change or enhancement label Jun 2, 2026
@kevmoo kevmoo requested a review from natebosch June 13, 2026 18:48
@kevmoo

kevmoo commented Jun 13, 2026

Copy link
Copy Markdown
Member Author

Most of the changes here are do to format changes and updating the generated workflow files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natebosch natebosch Awaiting requested review from natebosch

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

package:shelf_packages_handler package:shelf_proxy package:shelf_router_generator package:shelf_router package:shelf_static package:shelf_test_handler package:shelf_web_socket package:shelf type-infra A repository infrastructure change or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kevmoo