You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your PR. I see the need to provide customization to the hyperlinks, like using AttributedString to make the link actually a link.
As I saw in the code changes, the InlineElementComposer became BlockElementComposer, which will result in the link element cannot concatenate with plain texts and any other text elements. Because BlockElement's rendering logic is to stack each other one by one.
I'm wondering why to modify it, and if there are any possibilities to make it an InlineElement.
If I'm not mistaken links in markdown are in the form of [text](url) so no need for concatenation, right? I could not manage to use InlineElementComposer to render AnyView. This way you can return any type of view such as Button which was the purpose of doing this PR. But I might have missed some regression in your library. None that I've seen by the way with my markdown documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I based the custom view implementation on the
ImageElementComposerlogic so we can now provideAnyViewto render a link instead of plain text.