feat: RegionPreviewValue support (DEV-6300)#4110
Open
siers wants to merge 12 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4110 +/- ##
==========================================
+ Coverage 85.98% 86.06% +0.07%
==========================================
Files 538 538
Lines 30571 30586 +15
Branches 3559 3554 -5
==========================================
+ Hits 26286 26323 +37
+ Misses 4285 4263 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e1d5a32 to
0ca1d79
Compare
0ca1d79 to
0e90fe7
Compare
45d3564 to
bebe8ae
Compare
bebe8ae to
3ef462d
Compare
Contributor
Author
|
Ran claude as the reviewer, there are two things |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegionPreviewValuesupport (DEV-6300)New value type: a resource points at a
RegionviahasRegionPreview. Only the link (isRegionPreviewOf) is stored. The IIIF preview URL is computed at read time, never persisted.Pipeline
Change summary
knora-base.ttl&OntologyConstants.scala—RegionPreviewValue/hasRegionPreview/isRegionPreviewOf/iiifUrl; v51 → v52ValueMessagesV2.scala—RegionPreviewValueContentV2(value type, JSON-LD, parser);GeomValueContentV2.parsePointsApiComplexV2JsonLdRequestParser.scala,ResourceCreateModels.scala,ResourcesRepoLive.scala— write path: parse + persistisRegionPreviewOfConstructResponseUtilV2.scala— read path: dispatchRegionPreviewValue;iiifUrl = None(deferred to the service)ReadResourcesServiceLive.scala—augmentRegionPreviewValues: region geometry →pct:x,y,w,h, still-image filename → IIIF URLReadResourcesServiceLiveSpec.scala– finally has a standalone test! previously implicitly testedGravsearchTypeInspectionUtil.scala,ResourceMessagesV2.scala,Vocabulary.scala— supporting constants/accessors