Update DasherCore: crash fixes (#22, #23)#11
Merged
Conversation
Pulls in two DasherCore fixes for TestFlight crashes on build 32: 1. #22 — editOutput crash: reset cursorPos when editBuffer is cleared (3 of 4 TestFlight crashes — std::out_of_range in string::insert) 2. #23 — game mode crash: null-guard node in HandleEditEvent (1 of 4 TestFlight crashes — EXC_BAD_ACCESS at 0x54) DasherCore: 3ddedde2 -> 581093ef Signed-off-by: will wade <willwade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the DasherCore submodule to pull in two crash fixes for TestFlight build 32:
#22 — editOutput crash (3 of 4 TestFlight crashes)
dasher_reset_output_text(),dasher_reset(), anddasher_set_alphabet_id()clearededitBufferwithout resettingcursorPos. NexteditOutput()call hitstd::string::insert(pos, text)withpos > size()→std::out_of_range→ SIGABRT.cursorPos=0in all three buffer-clear functions + defensive clamp ineditOutput().#23 — game mode crash (1 of 4 TestFlight crashes)
TextOutputAction::executepassesnullptras the cause node toeditOutput.CGameModule::HandleEditEventdereferencesnode->offset()unconditionally → EXC_BAD_ACCESS at 0x54.if (!node) return;guard at top ofHandleEditEvent.DasherCore:
3ddedde2→581093efAfter merge, ship a new TestFlight build and all 4 crashes should be resolved.