Feature/lucide icons#5
Merged
Merged
Conversation
Replace all inline PathIcon elements with LucideIcon from the
Lucide.Avalonia NuGet package (v0.2.10), per RFC 0002.
Replaced icons:
- Toolbar: New (file-plus), Open (folder-open), Save, Play/Pause,
Position (flip-horizontal-2), Keyboard, Game Mode (gamepad-2),
Control Mode (mouse-pointer-click), Prefs (settings)
- Status bar: show/hide chevrons, back button
- Message pane: eye (toggle), volume-2 (speak), circle-stop (stop),
copy, clipboard-copy, clipboard-paste, ellipsis-vertical (more)
Updated styles to target LucideIcon instead of PathIcon.
Play/pause icon Kind now swaps dynamically in code-behind.
Uses {x:Static} binding for enum values (compiled bindings compat).
Mode button icon now reflects pane position: - Right: panel-right, Left: panel-left, Bottom: panel-bottom, Top: panel-top Game button swaps between Gamepad2 (inactive) and Pause (active), matching the Play/Pause button pattern.
Dark mode: ThemeDictionaries in App.axaml with Light/Dark variants for all custom brushes (BgLight, SurfaceLight, BorderLight, TextPrimary, etc). RequestedThemeVariant=Default follows the system setting. Tooltips: Added ToolTip.Tip to all toolbar buttons (New, Open, Save, Mode, Keyboard, Game, Control, Prefs) and message pane buttons (Eye, Speak, Stop, Copy, Copy All, Paste, More, Back). Theme cleanup: Replaced hardcoded #ECEFF1/#735A52/#EAE5E3/#DFDAD7 with DynamicResource bindings so they adapt to dark mode. Fixed CS8602 nullable warnings in UpdateChecker.cs and MainWindow.axaml.cs with null-forgiving operators.
TextBox.message-area had hardcoded #FFFFFF background. Changed to DynamicResource SurfaceLight so it adapts to theme (white in light, #25282B in dark).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue / RFC: #4
Type of change
Cross-platform impact
A core goal of Dasher v6 is feature parity across frontends. Help reviewers
see the blast radius:
If checked, I have opened / updated the feature matrix
(
website/src/data/feature-status.yaml) — linked PR: #(or confirmed this is genuinely platform-specific-only)
If checked, an RFC (
governance/rfcs) is linked: #Definition of Done
git commit -s