Skip to content

Fix editOutput crash: reset cursorPos when editBuffer is cleared #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwade merged 1 commit into from
Jun 19, 2026
Merged

Fix editOutput crash: reset cursorPos when editBuffer is cleared #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/CAPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,9 @@ struct dasher_ctx {
return static_cast<unsigned int>(m_owner->cursorPos);
}
void editOutput(const std::string& strText, Dasher::CDasherNode* pCause) override {
if (m_owner->cursorPos > m_owner->editBuffer.size()) {
m_owner->cursorPos = m_owner->editBuffer.size();
}
m_owner->editBuffer.insert(m_owner->cursorPos, strText);
m_owner->cursorPos += strText.size();
if (m_owner->outputCb && !strText.empty()) m_owner->outputCb(0, strText.c_str(), m_owner->outputCbUserData);
Expand Down Expand Up @@ -643,11 +646,13 @@ DASHER_API const char* dasher_get_output_text(dasher_ctx* ctx) {
DASHER_API void dasher_reset_output_text(dasher_ctx* ctx) {
if (!ctx) return;
ctx->editBuffer.clear();
ctx->cursorPos = 0;
}

DASHER_API void dasher_reset(dasher_ctx* ctx) {
if (!ctx || !ctx->intf) return;
ctx->editBuffer.clear();
ctx->cursorPos = 0;
ctx->intf->SetOffset(0, true);
}

Expand All @@ -660,6 +665,7 @@ DASHER_API const char* dasher_get_alphabet_id(dasher_ctx* ctx) {
DASHER_API void dasher_set_alphabet_id(dasher_ctx* ctx, const char* alphabet_id) {
if (!ctx || !ctx->intf || !alphabet_id) return;
ctx->editBuffer.clear();
ctx->cursorPos = 0;
if (!ctx->realized) {
ctx->pendingAlphabet = alphabet_id;
return;
Expand Down
Loading