Skip to content

Fix appearance model: late-seed dark companion after Realize #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwade merged 1 commit into from
Jun 20, 2026
+11 −0
Merged

Fix appearance model: late-seed dark companion after Realize #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/CAPI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,17 @@ int effectiveAppearanceValue(const dasher_ctx* ctx) {
// source of truth, so this can never clobber the user's explicit choice.
void resolveAppearance(dasher_ctx* ctx) {
if (!ctx || !ctx->intf) return;

// Late seed: ensureAppearanceInitialised may have run before Realize,
// when ColorIO wasn't available and the companion lookup failed.
// Retry now — once ColorIO exists, the lookup succeeds and fills the gap.
if (ctx->darkPalette.empty() && !ctx->lightPalette.empty()) {
if (auto* colorIO = ctx->intf->GetColorIO()) {
if (const Dasher::ColorPalette* comp = companionLookup(colorIO, ctx->lightPalette))
ctx->darkPalette = comp->PaletteName;
}
}

int eff = effectiveAppearanceValue(ctx);
std::string target = (eff == 1) ? ctx->lightPalette : ctx->darkPalette;
if (target.empty()) target = (eff == 1) ? ctx->darkPalette : ctx->lightPalette; // other side
Expand Down
Loading