refactor: move manager initialization from trait method to constructors #467
Draft
xdustinface wants to merge 2 commits intov0.42-devfrom
Draft
refactor: move manager initialization from trait method to constructors #467xdustinface wants to merge 2 commits intov0.42-devfrom
xdustinface wants to merge 2 commits intov0.42-devfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
github-actions
bot
added
the
merge-conflict
xdustinface
added a commit
that referenced
this pull request
Feb 25, 2026
Move the storage background persist worker spawn from `DiskStorageManager::new()` to a new `StorageManager::start()` trait method, called from `DashSpvClient::start()`. This prevents a tokio task leak when clients are created and destroyed without being started in #467.
xdustinface
force-pushed
the
refactor/move-initialization
branch
from
7d5adf1 to
c85abe0
Compare
github-actions
bot
removed
the
merge-conflict
xdustinface
force-pushed
the
refactor/move-initialization
branch
5 times, most recently
from
d655bb3 to
27aefe4
Compare
xdustinface
added a commit
to xdustinface/rust-dashcore
that referenced
this pull request
Feb 25, 2026
Move the storage background persist worker spawn from `DiskStorageManager::new()` to a new `StorageManager::start()` trait method, called from `DashSpvClient::start()`. This prevents a tokio task leak when clients are created and destroyed without being started in dashpay#467.
xdustinface
force-pushed
the
refactor/move-initialization
branch
from
27aefe4 to
e364976
Compare
github-actions
bot
added
the
merge-conflict
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
xdustinface
force-pushed
the
refactor/move-initialization
branch
from
e364976 to
89ab17e
Compare
github-actions
bot
removed
the
merge-conflict
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
github-actions
bot
added
the
merge-conflict
We currently just silently ignore any failure inside the sync coordinator or `monitor_network` thread. This PR propagates them and also adds a FFI callback structure which can be set to receive notifications about errors inside the SPV client.
- Moves initialization logic out of the `SyncManager::initialize()` trait method and into each manager's constructor. - Genesis block is now stored before managers are created, so they can read the tip during construction. - The `SyncCoordinator` seeds initial progress from actual manager state instead of default and uses `WatchStream::from_changes` to avoid re-emitting all initial progresses.
xdustinface
force-pushed
the
refactor/move-initialization
branch
from
89ab17e to
8e08c35
Compare
github-actions
bot
removed
the
merge-conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyncManager::initialize()trait method and into each manager's constructor.SyncCoordinatorseeds initial progress from actual manager state instead of default and usesWatchStream::from_changesto avoid re-emitting all initial progresses.Based on:
SyncState::Initializingvariant #465ensure_not_started()guard #466