chore: improve ASAN stack trace and symbolization#475
chore: improve ASAN stack trace and symbolization#475xdustinface wants to merge 1 commit intov0.42-devfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughModifies the Address Sanitizer (ASAN) GitHub Actions workflow: adds Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/sanitizer.yml (1)
62-62: Consider adding-Cforce-frame-pointers=yesto the TSAN job for parity.The ASAN job now preserves frame pointers for more complete stack traces. TSAN can benefit from the same flag in environments where DWARF-based unwinding is incomplete.
♻️ Optional: propagate frame-pointer flag to TSAN
- RUSTFLAGS: "-Zsanitizer=thread -Cdebuginfo=2" + RUSTFLAGS: "-Zsanitizer=thread -Cdebuginfo=2 -Cforce-frame-pointers=yes"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/sanitizer.yml at line 62, Update the TSAN job's RUSTFLAGS value (currently set to "-Zsanitizer=thread -Cdebuginfo=2") to also include "-Cforce-frame-pointers=yes" so frame pointers are preserved for better stack traces; modify the RUSTFLAGS assignment in the TSAN job to "-Zsanitizer=thread -Cdebuginfo=2 -Cforce-frame-pointers=yes".
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/sanitizer.yml:
- Line 62: Update the TSAN job's RUSTFLAGS value (currently set to
"-Zsanitizer=thread -Cdebuginfo=2") to also include "-Cforce-frame-pointers=yes"
so frame pointers are preserved for better stack traces; modify the RUSTFLAGS
assignment in the TSAN job to "-Zsanitizer=thread -Cdebuginfo=2
-Cforce-frame-pointers=yes".
github-actions
bot
added
the
merge-conflict
|
This PR has merge conflicts with the base branch. Please rebase or merge the base branch into your branch to resolve them. |
Use `allow_addr2line=1` so ASAN falls back to the pre-installed `addr2line` for symbolization. This avoids LLVM version mismatch issues between the system `llvm-symbolizer` and nightly Rust's LLVM, and works regardless of which LLVM version nightly uses. Also enable `force-frame-pointers` for more complete stack traces.
xdustinface
force-pushed
the
chore/addr2line
branch
from
77c4f63 to
9b66bd1
Compare
github-actions
bot
removed
the
merge-conflict
2 participants
Use
allow_addr2line=1so ASAN falls back to the pre-installedaddr2linefor symbolization. This avoids LLVM version mismatch issues between the systemllvm-symbolizerand nightly Rust's LLVM, and works regardless of which LLVM version nightly uses. Also enableforce-frame-pointersfor more complete stack traces.Summary by CodeRabbit
Note: This release contains no user-facing changes.