Skip to content

chore(key-wallet): drop FeeEstimator#480

Open
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-fee-estimatir
Open

chore(key-wallet): drop FeeEstimator#480
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-fee-estimatir

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Feb 26, 2026

This FeeEstimator doesn't really estimate any fee and is not being used anyware

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bc6592 and 607a9ac.

📒 Files selected for processing (2)
  • key-wallet-manager/src/lib.rs
  • key-wallet/src/wallet/managed_wallet_info/fee.rs
💤 Files with no reviewable changes (1)
  • key-wallet/src/wallet/managed_wallet_info/fee.rs

📝 Walkthrough

Walkthrough

This PR removes the public FeeEstimator type and all associated fee estimation logic from the key-wallet crate, including its methods and tests. The FeeRate export path is updated to a direct module reference, while FeeRate, FeeLevel, and transaction sizing functionality remain unchanged.

Changes

Cohort / File(s) Summary
Export Updates
key-wallet-manager/src/lib.rs
Removed public export of FeeEstimator; updated FeeRate export path from aggregate fee module re-export to direct module path.
Fee Estimator Removal
key-wallet/src/wallet/managed_wallet_info/fee.rs
Removed entire FeeEstimator type, all associated methods (new, update_estimates, estimate_fee, estimate_fee_level, clamp_fee_rate, set_min_fee_rate, set_max_fee_rate), Default implementation, and related tests. FeeRate, FeeLevel, and transaction sizing logic remain intact.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A simplification hops along the way,
Removing estimators that had their day,
FeeRate stands tall, clear and bright,
The API grows lean, the exports just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removal of the FeeEstimator type from the key-wallet crate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/drop-fee-estimatir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants