Config remote sync command #4289
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
commented
Jan 15, 2026
| } | ||
|
|
||
| // SaveFiles writes all file changes to disk. | ||
| func SaveFiles(ctx context.Context, b *bundle.Bundle, files []FileChange) error { |
Contributor
Author
There was a problem hiding this comment.
Q: Does it make sense to use yamlsaver here? Not sure what the benefits would be
ilyakuz-db
commented
Jan 15, 2026
| } | ||
|
|
||
| // Check for key-value selector: [key='value'] | ||
| if key, value, ok := n.KeyValue(); ok { |
Contributor
Author
There was a problem hiding this comment.
This part is probably not efficient and should be part of the mapping, not a string converter. Keeping it as is for now, as this makes it more modular. I'll see if it needs to be updated in next PRs
Collaborator
|
Commit: ee2564d
19 interesting tests: 10 KNOWN, 7 RECOVERED, 1 SKIP, 1 flaky
Top 50 slowest tests (at least 2 minutes):
|
ilyakuz-db
commented
Jan 15, 2026
| // Example: "resources.jobs.my_job" -> type="jobs", name="my_job" | ||
| func parseResourceKey(resourceKey string) (resourceType, resourceName string, err error) { | ||
| parts := strings.Split(resourceKey, ".") | ||
| if len(parts) < 3 || parts[0] != "resources" { |
Contributor
Author
There was a problem hiding this comment.
Hardcoded length for now, I'll check in next PRs if it makes sense to make this more generic
ilyakuz-db
commented
Jan 15, 2026
| return fmt.Errorf("failed to detect changes: %w", err) | ||
| } | ||
|
|
||
| files, err := configsync.GenerateYAMLFiles(ctx, b, changes) |
Contributor
Author
There was a problem hiding this comment.
This could potentially be split into 2 separate phases: applyChanges and generateYaml. I will check what suits the best when I am working on preserving original YAML formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests