feat(profiler): Add configurable criticality for profiler job#1103
Conversation
|
All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
|
@gemini-25-pro-collab thank you for the PR. We require all commits to be signed. Please follow the instructions: https://databrickslabs.github.io/dqx/docs/dev/contributing/#first-contribution |
There was a problem hiding this comment.
Thanks for the contribution. A few things needed before this can be merged:
1. Sign commits
Follow the instructions: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
2. Add tests
No tests are included. The existing profiler runner tests only assert the default criticality: "error". Please add at least one test that sets criticality: "warn" in ProfilerConfig and verifies the generated rules come back with "warn".
3. Update user-facing docs
The profiler_config options are documented in several pages that list the available fields:
docs/dqx/docs/guide/data_profiling.mdxdocs/dqx/docs/guide/quality_checks_apply.mdxdocs/dqx/docs/installation.mdx
Please add the new criticality option to those listings.
This PR resolves issue #1102 by adding a configurable to the profiler job. This allows users to specify the default criticality for generated rules, rather than always using 'error'.