Skip to content

feat(profiler): Add configurable criticality for profiler job#1103

Open
gemini-25-pro-collab wants to merge 2 commits intodatabrickslabs:mainfrom
gemini-25-pro-collab:feature/configurable-profiler-criticality-1102
Open

feat(profiler): Add configurable criticality for profiler job#1103
gemini-25-pro-collab wants to merge 2 commits intodatabrickslabs:mainfrom
gemini-25-pro-collab:feature/configurable-profiler-criticality-1102

Conversation

@gemini-25-pro-collab
Copy link
Copy Markdown

This PR resolves issue #1102 by adding a configurable to the profiler job. This allows users to specify the default criticality for generated rules, rather than always using 'error'.

@gemini-25-pro-collab gemini-25-pro-collab requested a review from a team as a code owner March 31, 2026 17:38
@gemini-25-pro-collab gemini-25-pro-collab requested review from gergo-databricks and removed request for a team March 31, 2026 17:38
@github-actions
Copy link
Copy Markdown

All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@mwojtyczka
Copy link
Copy Markdown
Contributor

@gemini-25-pro-collab thank you for the PR. We require all commits to be signed. Please follow the instructions: https://databrickslabs.github.io/dqx/docs/dev/contributing/#first-contribution

Copy link
Copy Markdown
Contributor

@mwojtyczka mwojtyczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A few things needed before this can be merged:

1. Sign commits

Follow the instructions: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

2. Add tests

No tests are included. The existing profiler runner tests only assert the default criticality: "error". Please add at least one test that sets criticality: "warn" in ProfilerConfig and verifies the generated rules come back with "warn".

3. Update user-facing docs

The profiler_config options are documented in several pages that list the available fields:

  • docs/dqx/docs/guide/data_profiling.mdx
  • docs/dqx/docs/guide/quality_checks_apply.mdx
  • docs/dqx/docs/installation.mdx

Please add the new criticality option to those listings.

@mwojtyczka mwojtyczka added under-review This PR is currently being reviewed by one of DQX maintainers. needs-changes Changes required after review and removed under-review This PR is currently being reviewed by one of DQX maintainers. labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-changes Changes required after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants